[ 
https://issues.apache.org/jira/browse/HDFS-8684?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14614491#comment-14614491
 ] 

Walter Su commented on HDFS-8684:
---------------------------------

>...this part is used to update the quota.
Oh..Now I get it. Thanks Vinay and Yi for explanation.
>... it's not reachable, from the code logic itself, we should do this fix.
Agree. We fix this because {{computeFileSize}} itself only counts file size. 
Let's take care of how snapshot feature utilize it later when striping support 
snapshot.
>...Sure, do it in the update patch
Thanks.
+1 for 002 patch.

> Erasure Coding: fix some block number calculation for striped block
> -------------------------------------------------------------------
>
>                 Key: HDFS-8684
>                 URL: https://issues.apache.org/jira/browse/HDFS-8684
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>            Reporter: Yi Liu
>            Assignee: Yi Liu
>         Attachments: HDFS-8684-HDFS-7285.001.patch, 
> HDFS-8684-HDFS-7285.002.patch
>
>
> in INodeFile#computeFileSize, the file size calucation for underconstruction 
> striped block is incorrect.
> in BlockManager#chooseExcessReplicasStriped, the {{if (nonExcess.size() <= 
> groupSize) {}} is incorrect.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to