[
https://issues.apache.org/jira/browse/HDFS-8684?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14614535#comment-14614535
]
Vinayakumar B commented on HDFS-8684:
-------------------------------------
bq. Only if usePreferredBlockSize4LastUcBlock is true, we can say It's used to
update the quota, but computeFileSize itself only counts file size, not include
redundant replicas. I agree it's not reachable for updating the quota of
striped block, and agree that the comment is not correct. How about removing
the comment? It will not affect updating the quota of striped block since it's
not reachable, and from the code logic itself, we should do this fix.
Yes, thats correct. {{usePreferredBlockSize4LastUcBlock}} is true only in
{{FileWithSnapshotFeature#updateQuotaAndCollectBlocks(..)}}. And morever, this
will be called only if there is change in replication in snapshot diffs, which
is ideally not possible in case of striped files.
Anyway, other changes looks good.
> Erasure Coding: fix some block number calculation for striped block
> -------------------------------------------------------------------
>
> Key: HDFS-8684
> URL: https://issues.apache.org/jira/browse/HDFS-8684
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Reporter: Yi Liu
> Assignee: Yi Liu
> Attachments: HDFS-8684-HDFS-7285.001.patch,
> HDFS-8684-HDFS-7285.002.patch
>
>
> in INodeFile#computeFileSize, the file size calucation for underconstruction
> striped block is incorrect.
> in BlockManager#chooseExcessReplicasStriped, the {{if (nonExcess.size() <=
> groupSize) {}} is incorrect.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
