[
https://issues.apache.org/jira/browse/HDFS-1481?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12934211#action_12934211
]
Konstantin Shvachko commented on HDFS-1481:
-------------------------------------------
Looks like you are right. The new image checksum is verified against the one in
the signature after the image is loaded from disk. So my suggestion would be an
optimization for failing faster, but it is optional.
+1 the patch looks good. It would be good to remove the unused import of
InetAddress in Checkpointer.
> NameNode should validate fsimage before rolling
> -----------------------------------------------
>
> Key: HDFS-1481
> URL: https://issues.apache.org/jira/browse/HDFS-1481
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: name-node
> Affects Versions: 0.22.0
> Reporter: Hairong Kuang
> Assignee: Hairong Kuang
> Fix For: 0.22.0
>
> Attachments: trunkValidateUpload.patch
>
>
> We had an incident that the fsimage at secondary NameNode was truncated but
> got uploaded to the primary NameNode. The primary NameNode simply rolled the
> image without checking its integrity, therefore causing the fsimage to
> corrupt. The primary NameNode should check the new image's integrity before
> rolling fsimage.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
