[
https://issues.apache.org/jira/browse/HDFS-1481?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12934641#action_12934641
]
Hairong Kuang commented on HDFS-1481:
-------------------------------------
ant test-patch results:
[exec] -1 overall.
[exec]
[exec] +1 @author. The patch does not contain any @author tags.
[exec]
[exec] -1 tests included. The patch doesn't appe
[exec] ar to include any new or modified tests.
[exec] Please justify why no new tests are needed
for this patch.
[exec] Also please list what manual steps were
performed to verify this patch.
[exec]
[exec] +1 javadoc. The javadoc tool did not generate any warning
messages. [exec]
[exec] +1 javac. The applied patch does not increase the total number
of javac compiler warnings. [exec]
[exec] +1 findbugs. The patch does not introduce any new Findbugs
(version 1.3.9) warnings. [exec]
[exec] +1 release audit. The applied patch does not increase the
total number of release audit warnings. [exec]
[exec] +1 system test framework. The patch passed system test
framework compile.
This change is simple but too tricky to write a unit test. I plan to commit it
without a unit test.
Ant test failed. But all failed ones are known:
TestBlockRecovery
TestHDFSTrash
TestStorageRestore
TestBalancer
TestSaveNamespace
> NameNode should validate fsimage before rolling
> -----------------------------------------------
>
> Key: HDFS-1481
> URL: https://issues.apache.org/jira/browse/HDFS-1481
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: name-node
> Affects Versions: 0.22.0
> Reporter: Hairong Kuang
> Assignee: Hairong Kuang
> Fix For: 0.22.0
>
> Attachments: trunkValidateUpload.patch, trunkValidateUpload1.patch
>
>
> We had an incident that the fsimage at secondary NameNode was truncated but
> got uploaded to the primary NameNode. The primary NameNode simply rolled the
> image without checking its integrity, therefore causing the fsimage to
> corrupt. The primary NameNode should check the new image's integrity before
> rolling fsimage.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
