[ https://issues.apache.org/jira/browse/HDFS-8751?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14621995#comment-14621995 ]
Hadoop QA commented on HDFS-8751: --------------------------------- \\ \\ | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || | {color:blue}0{color} | pre-patch | 22m 9s | Pre-patch trunk compilation is healthy. | | {color:green}+1{color} | @author | 0m 0s | The patch does not contain any @author tags. | | {color:green}+1{color} | tests included | 0m 0s | The patch appears to include 1 new or modified test files. | | {color:green}+1{color} | javac | 10m 7s | There were no new javac warning messages. | | {color:green}+1{color} | javadoc | 11m 8s | There were no new javadoc warning messages. | | {color:green}+1{color} | release audit | 0m 25s | The applied patch does not increase the total number of release audit warnings. | | {color:red}-1{color} | checkstyle | 1m 38s | The applied patch generated 1 new checkstyle issues (total was 41, now 38). | | {color:green}+1{color} | whitespace | 0m 0s | The patch has no lines that end in whitespace. | | {color:green}+1{color} | install | 1m 42s | mvn install still works. | | {color:green}+1{color} | eclipse:eclipse | 0m 48s | The patch built with eclipse:eclipse. | | {color:green}+1{color} | findbugs | 3m 6s | The patch does not introduce any new Findbugs (version 3.0.0) warnings. | | {color:green}+1{color} | native | 3m 46s | Pre-build of native portion | | {color:red}-1{color} | hdfs tests | 77m 27s | Tests failed in hadoop-hdfs. | | | | 132m 19s | | \\ \\ || Reason || Tests || | Failed unit tests | hadoop.hdfs.server.namenode.ha.TestStandbyIsHot | | Timed out tests | org.apache.hadoop.hdfs.TestEncryptedTransfer | \\ \\ || Subsystem || Report/Notes || | Patch URL | http://issues.apache.org/jira/secure/attachment/12744650/HDFS-8751.00.patch | | Optional Tests | javadoc javac unit findbugs checkstyle | | git revision | trunk / d66302e | | checkstyle | https://builds.apache.org/job/PreCommit-HDFS-Build/11655/artifact/patchprocess/diffcheckstylehadoop-hdfs.txt | | hadoop-hdfs test log | https://builds.apache.org/job/PreCommit-HDFS-Build/11655/artifact/patchprocess/testrun_hadoop-hdfs.txt | | Test Results | https://builds.apache.org/job/PreCommit-HDFS-Build/11655/testReport/ | | Java | 1.7.0_55 | | uname | Linux asf908.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux | | Console output | https://builds.apache.org/job/PreCommit-HDFS-Build/11655/console | This message was automatically generated. > Remove setBlocks API from INodeFile and misc code cleanup > --------------------------------------------------------- > > Key: HDFS-8751 > URL: https://issues.apache.org/jira/browse/HDFS-8751 > Project: Hadoop HDFS > Issue Type: Bug > Components: namenode > Affects Versions: 2.7.0 > Reporter: Zhe Zhang > Assignee: Zhe Zhang > Fix For: 2.8.0 > > Attachments: HDFS-8751.00.patch > > > The public {{INodeFile#setBlocks}} API, when used outside {{INodeFile}}, is > always called with {{null}}. Therefore we should replace it with a safer > {{clearBlocks}} API. Also merging code cleanups from HDFS-7285 branch. -- This message was sent by Atlassian JIRA (v6.3.4#6332)