[
https://issues.apache.org/jira/browse/HDFS-8751?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14622073#comment-14622073
]
Rakesh R commented on HDFS-8751:
--------------------------------
Thanks [~zhz]. Just few minor comments:
# Could you change {code}/** Set the blocks. */{code} to {code}/** Clear the
blocks. */{code}.
# There is one minor checkstyle warning, please fix the same.
+1 (non-binding) once this is addressed.
> Remove setBlocks API from INodeFile and misc code cleanup
> ---------------------------------------------------------
>
> Key: HDFS-8751
> URL: https://issues.apache.org/jira/browse/HDFS-8751
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: namenode
> Affects Versions: 2.7.0
> Reporter: Zhe Zhang
> Assignee: Zhe Zhang
> Fix For: 2.8.0
>
> Attachments: HDFS-8751.00.patch
>
>
> The public {{INodeFile#setBlocks}} API, when used outside {{INodeFile}}, is
> always called with {{null}}. Therefore we should replace it with a safer
> {{clearBlocks}} API. Also merging code cleanups from HDFS-7285 branch.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
