[ 
https://issues.apache.org/jira/browse/HDFS-8670?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14627934#comment-14627934
 ] 

J.Andreina commented on HDFS-8670:
----------------------------------

Thanks [~mingma] .

I have updated the patch as per your review comments.

bq.Any reason it changes to call fetchDatanodes with parameter 
removeDecommissionNode set to false?
Seems there is an issue in the logic for removing  decommission node from 
live/dead node list .I have raised a separate jira for the same (HDFS-8780).

Please review the patch.


> Better to exclude decommissioned nodes for namenode NodeUsage JMX
> -----------------------------------------------------------------
>
>                 Key: HDFS-8670
>                 URL: https://issues.apache.org/jira/browse/HDFS-8670
>             Project: Hadoop HDFS
>          Issue Type: Bug
>            Reporter: Ming Ma
>            Assignee: J.Andreina
>         Attachments: HDFS-8670.1.patch, HDFS-8670.2.patch, HDFS-8670.3.patch
>
>
> The namenode NodeUsage JMX has Max, Median, Min and Standard Deviation of 
> DataNodes usage, it currently includes decommissioned nodes for the 
> calculation. However, given balancer doesn't work on decommissioned nodes and 
> sometimes we could have nodes stay in decommissioned states for a long time; 
> it might be better to exclude decommissioned nodes for the metrics 
> calculation.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to