[
https://issues.apache.org/jira/browse/HDFS-8670?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14629217#comment-14629217
]
Ming Ma commented on HDFS-8670:
-------------------------------
Thanks [~andreina]. Overall it looks good.
The two test cases have quite amount of overlaps. It seems the only differences
between decommissioned test case and decommission_inprogress test case are the
number of datanodes and the expected decommission state the test cases wait
for. Maybe these two test cases can call a common function that takes number of
datanodes and expected decommission state as parameters?
> Better to exclude decommissioned nodes for namenode NodeUsage JMX
> -----------------------------------------------------------------
>
> Key: HDFS-8670
> URL: https://issues.apache.org/jira/browse/HDFS-8670
> Project: Hadoop HDFS
> Issue Type: Bug
> Reporter: Ming Ma
> Assignee: J.Andreina
> Attachments: HDFS-8670.1.patch, HDFS-8670.2.patch, HDFS-8670.3.patch
>
>
> The namenode NodeUsage JMX has Max, Median, Min and Standard Deviation of
> DataNodes usage, it currently includes decommissioned nodes for the
> calculation. However, given balancer doesn't work on decommissioned nodes and
> sometimes we could have nodes stay in decommissioned states for a long time;
> it might be better to exclude decommissioned nodes for the metrics
> calculation.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)