[
https://issues.apache.org/jira/browse/HDFS-8499?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14643747#comment-14643747
]
Tsz Wo Nicholas Sze commented on HDFS-8499:
-------------------------------------------
> I was pointing out that BlockInfoUnderConstruction itself no longer is-a
> BlockInfo. That changes how NN uses BlockInfoUnderConstruction. ...
Could you give some examples?
> In the beginning of the project we chose to extend BlockInfo to handle block
> groups, instead of building something like BlockGroupInfo from scratch. One
> of the most important reasons was that most block mgmt logics (including UC
> logic) are orthogonal to striping logic. ...
You seems saying BlockInfo could handle both contiguous and striped blocks.
No? Actually, we extend BlockInfo to BlockInfoContiguous and BlockInfoStriped
so that contiguous blocks and striped blocks can be handled differently.
Similarly for UC, we want to handle contiguous and striped uc blocks
differently.
Anyway, it does not make sense to handle the contiguous block logic differently
in BlockInfoContiguous and BlockInfoContiguousUC,
(and handle the striped block logic differently in BlockInfoStriped and
BlockInfoStripedUC.) So that we don't want to choose Design #1.
> In the reworked structure, ...
We don't need to rework anything. It is already done in the HDFS-7285 branch.
I think we should simply revert the HDFS-8499 and the related patches. BTW,
HDFS-8499 and the related patches are some bigger change that we probably
should not commit to trunk in the first place before the merging HDFS-7285.
> Refactor BlockInfo class hierarchy with static helper class
> -----------------------------------------------------------
>
> Key: HDFS-8499
> URL: https://issues.apache.org/jira/browse/HDFS-8499
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: namenode
> Affects Versions: 2.7.0
> Reporter: Zhe Zhang
> Assignee: Zhe Zhang
> Fix For: 2.8.0
>
> Attachments: HDFS-8499.00.patch, HDFS-8499.01.patch,
> HDFS-8499.02.patch, HDFS-8499.03.patch, HDFS-8499.04.patch,
> HDFS-8499.05.patch, HDFS-8499.06.patch, HDFS-8499.07.patch,
> HDFS-8499.UCFeature.patch, HDFS-bistriped.patch
>
>
> In HDFS-7285 branch, the {{BlockInfoUnderConstruction}} interface provides a
> common abstraction for striped and contiguous UC blocks. This JIRA aims to
> merge it to trunk.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
