[
https://issues.apache.org/jira/browse/HDFS-8155?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14694416#comment-14694416
]
Chris Douglas commented on HDFS-8155:
-------------------------------------
Minor points; someone should look at the OAuth changes specifically.
* Instead of adding its own {{Time}} classes under utils, it may make sense to
move
[Clock|https://git1-us-west.apache.org/repos/asf?p=hadoop.git;a=blob;f=hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/util/Clock.java;h=fe55993d5db520b542e21bfa7e2dfb82011a60bc;hb=refs/heads/trunk]
from YARN to Common. Or use the
[Timer|https://git1-us-west.apache.org/repos/asf?p=hadoop.git;a=blob;f=hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/Timer.java;h=e1e21a7220013016c443923331483489641d1306;hb=refs/heads/trunk]
class in Common, if that's sufficient.
* If the timing classes could use existing code, the Utils class could be
package-private in {{o.a.h.hdfs.web.oauth2}}
* Please add scope/visibility annotations to classes
* The protected, mutable fields in the {{AccessTokenProvider}} classes can be
private. {{nextRefreshMSSinceEpoch}} in {{Timer}}, also (constructor should
explicitly init to 0 instead of self-ref)
* Instead of requiring {{initialize}}, would it make sense for
{{AccessTokenProvider}} implementations to implement {{Configurable}} as
appropriate?
* What is the expectation for multithreaded access for these classes?
* If {{AccessTokenProvider}} were an abstract class, could the impls share more
of the code in refresh? Superficially, they look very similar...
* Should refresh throw {{IOException}} instead of {{IllegalArgumentException}},
since {{AccessTokenProvider::getAccessToken}} supports it?
> Support OAuth2 in WebHDFS
> -------------------------
>
> Key: HDFS-8155
> URL: https://issues.apache.org/jira/browse/HDFS-8155
> Project: Hadoop HDFS
> Issue Type: New Feature
> Components: webhdfs
> Reporter: Jakob Homan
> Assignee: Jakob Homan
> Attachments: HDFS-8155-1.patch
>
>
> WebHDFS should be able to accept OAuth2 credentials.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
