[ 
https://issues.apache.org/jira/browse/HDFS-8155?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14711874#comment-14711874
 ] 

Chris Nauroth commented on HDFS-8155:
-------------------------------------

Hi [~jghoman].  Nice work!  I have a few comments.

# {{ConfRefreshTokenBasedAccessTokenProvider}}, 
{{ConfRefreshTokenBasedAccessTokenProvider}}: There are no timeouts specified 
in the calls to the refresh URL.  Timeouts can be controlled by calling 
{{client.setConnectTimeout}} and {{client.setReadTimeout}}.
# {{AccessTokenProvider}}: *Optional* - consider extending {{Configured}} so 
that it inherits the implementations of {{getConf}} and {{setConf}} for free.
# WebHDFS.md: Typo: "toekns" instead of "tokens"
# Please address the javac and checkstyle warnings.

[~chris.douglas], it looks like the most recent version of the patch has 
addressed your feedback.  Do you agree?

> Support OAuth2 in WebHDFS
> -------------------------
>
>                 Key: HDFS-8155
>                 URL: https://issues.apache.org/jira/browse/HDFS-8155
>             Project: Hadoop HDFS
>          Issue Type: New Feature
>          Components: webhdfs
>            Reporter: Jakob Homan
>            Assignee: Jakob Homan
>         Attachments: HDFS-8155-1.patch, HDFS-8155.002.patch
>
>
> WebHDFS should be able to accept OAuth2 credentials.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to