[
https://issues.apache.org/jira/browse/HDFS-8934?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14710430#comment-14710430
]
Haohui Mai commented on HDFS-8934:
----------------------------------
bq. look at Andrew's old JIRAs doing this for various classes....
Moving towards slf4j is great. Indeed issues might come up, but I'm happy as
long as the issues are addressed quickly.
Are you talking about this one?
https://issues.apache.org/jira/browse/HDFS-7712?focusedCommentId=14304368&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14304368
and this one?
https://issues.apache.org/jira/browse/HDFS-7411?focusedCommentId=14306261&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14306261
The changes of slf4j made that NN failed to come up and resulted in a blocker
bug (HDFS-7734). It looks to me it is pretty severe and I'm glad it is quickly
addressed.
I wonder, what's your take on what should be attributed for the
destabilization? Should we blame slf4j, or should we blame the author? If it is
the former, we can consider revisiting the decision on moving towards slf4j. If
it is the latter, maybe we should consider requiring more reviews and possibly
suggesting him / her making changes in a separate branch first?
> Move ShortCircuitShm to hdfs-client
> -----------------------------------
>
> Key: HDFS-8934
> URL: https://issues.apache.org/jira/browse/HDFS-8934
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: build
> Reporter: Mingliang Liu
> Assignee: Mingliang Liu
> Fix For: 2.8.0
>
> Attachments: HDFS-8934.000.patch, HDFS-8934.001.patch
>
>
> This jira tracks the effort of moving the {{ShortCircuitShm}} class into the
> hdfs-client module.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
