[
https://issues.apache.org/jira/browse/HDFS-9002?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14728187#comment-14728187
]
Hadoop QA commented on HDFS-9002:
---------------------------------
\\
\\
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | pre-patch | 19m 40s | Pre-patch trunk compilation is
healthy. |
| {color:green}+1{color} | @author | 0m 0s | The patch does not contain any
@author tags. |
| {color:green}+1{color} | tests included | 0m 0s | The patch appears to
include 8 new or modified test files. |
| {color:green}+1{color} | javac | 7m 53s | There were no new javac warning
messages. |
| {color:red}-1{color} | javadoc | 9m 56s | The applied patch generated 2
additional warning messages. |
| {color:green}+1{color} | release audit | 0m 24s | The applied patch does
not increase the total number of release audit warnings. |
| {color:red}-1{color} | checkstyle | 2m 31s | The applied patch generated
51 new checkstyle issues (total was 97, now 148). |
| {color:green}+1{color} | whitespace | 0m 5s | The patch has no lines that
end in whitespace. |
| {color:green}+1{color} | install | 1m 37s | mvn install still works. |
| {color:green}+1{color} | eclipse:eclipse | 0m 33s | The patch built with
eclipse:eclipse. |
| {color:red}-1{color} | findbugs | 4m 30s | The patch appears to introduce 1
new Findbugs (version 3.0.0) warnings. |
| {color:green}+1{color} | native | 3m 15s | Pre-build of native portion |
| {color:red}-1{color} | hdfs tests | 101m 44s | Tests failed in hadoop-hdfs. |
| {color:green}+1{color} | hdfs tests | 0m 29s | Tests passed in
hadoop-hdfs-client. |
| | | 152m 42s | |
\\
\\
|| Reason || Tests ||
| FindBugs | module:hadoop-hdfs-client |
| Failed unit tests |
hadoop.hdfs.tools.offlineImageViewer.TestOfflineImageViewerForContentSummary |
| | hadoop.hdfs.TestSafeMode |
| | hadoop.hdfs.TestHFlush |
| | hadoop.hdfs.TestModTime |
| | hadoop.hdfs.server.blockmanagement.TestBlockManager |
| | hadoop.hdfs.server.datanode.TestReadOnlySharedStorage |
| | hadoop.hdfs.TestReservedRawPaths |
| | hadoop.hdfs.web.TestHttpsFileSystem |
| | hadoop.hdfs.TestRemoteBlockReader2 |
| | hadoop.hdfs.server.blockmanagement.TestRBWBlockInvalidation |
| | hadoop.hdfs.TestReplication |
| | hadoop.hdfs.TestBlocksScheduledCounter |
| | hadoop.hdfs.server.datanode.TestDataNodeVolumeFailureReporting |
| | hadoop.hdfs.TestDFSInotifyEventInputStream |
| | hadoop.hdfs.TestAbandonBlock |
| | hadoop.hdfs.TestSetTimes |
| | hadoop.hdfs.TestDFSFinalize |
| | hadoop.hdfs.web.TestFSMainOperationsWebHdfs |
| | hadoop.hdfs.server.blockmanagement.TestNodeCount |
| | hadoop.hdfs.TestAppendDifferentChecksum |
| | hadoop.hdfs.TestHDFSFileSystemContract |
| | hadoop.hdfs.tools.TestDFSZKFailoverController |
| | hadoop.hdfs.server.datanode.TestNNHandlesCombinedBlockReport |
| | hadoop.hdfs.TestDFSShell |
| | hadoop.hdfs.TestMissingBlocksAlert |
| | hadoop.hdfs.server.balancer.TestBalancerWithHANameNodes |
| | hadoop.hdfs.TestFileCreationClient |
| | hadoop.hdfs.TestClientReportBadBlock |
| | hadoop.hdfs.web.TestWebHDFS |
| | hadoop.hdfs.TestSmallBlock |
| | hadoop.hdfs.TestHdfsAdmin |
| | hadoop.hdfs.server.blockmanagement.TestComputeInvalidateWork |
| | hadoop.hdfs.TestReadWhileWriting |
| | hadoop.hdfs.web.TestWebHdfsTokens |
| | hadoop.hdfs.server.datanode.TestTransferRbw |
| | hadoop.hdfs.TestFileCreation |
| | hadoop.hdfs.TestRead |
| | hadoop.hdfs.tools.TestDebugAdmin |
| | hadoop.hdfs.crypto.TestHdfsCryptoStreams |
| | hadoop.hdfs.server.datanode.TestBlockHasMultipleReplicasOnSameDN |
| | hadoop.hdfs.qjournal.TestSecureNNWithQJM |
| | hadoop.hdfs.TestClientProtocolForPipelineRecovery |
| | hadoop.hdfs.server.datanode.TestDataNodeMetrics |
| | hadoop.hdfs.TestWriteConfigurationToDFS |
| | hadoop.hdfs.TestParallelShortCircuitReadNoChecksum |
| | hadoop.hdfs.server.mover.TestStorageMover |
| | hadoop.hdfs.tools.offlineImageViewer.TestOfflineImageViewerForAcl |
| | hadoop.hdfs.TestRenameWhileOpen |
| | hadoop.hdfs.TestDFSClientRetries |
| | hadoop.hdfs.TestSnapshotCommands |
| | hadoop.hdfs.tools.TestDFSAdminWithHA |
| | hadoop.hdfs.TestEncryptionZonesWithKMS |
| | hadoop.hdfs.TestFileAppend |
| | hadoop.hdfs.TestLargeBlock |
| | hadoop.hdfs.TestFileCorruption |
| | hadoop.hdfs.TestQuota |
| | hadoop.hdfs.tools.TestDFSHAAdminMiniCluster |
| | hadoop.hdfs.TestRemoteBlockReader |
| | hadoop.hdfs.TestDFSShellGenericOptions |
| | hadoop.hdfs.TestHDFSServerPorts |
| | hadoop.hdfs.tools.TestDFSAdmin |
| | hadoop.hdfs.server.balancer.TestBalancerWithNodeGroup |
| | hadoop.hdfs.TestLocalDFS |
| | hadoop.hdfs.TestLease |
| | hadoop.hdfs.web.TestWebHdfsFileSystemContract |
| | hadoop.hdfs.server.datanode.TestStorageReport |
| | hadoop.hdfs.web.TestWebHdfsWithMultipleNameNodes |
| | hadoop.hdfs.server.blockmanagement.TestBlocksWithNotEnoughRacks |
| | hadoop.hdfs.server.datanode.TestDataNodeECN |
| | hadoop.hdfs.TestIsMethodSupported |
| | hadoop.hdfs.TestWriteRead |
| | hadoop.hdfs.server.blockmanagement.TestPendingReplication |
| | hadoop.hdfs.TestFileAppend2 |
| | hadoop.hdfs.TestSetrepIncreasing |
| | hadoop.hdfs.TestDatanodeDeath |
| | hadoop.hdfs.web.TestWebHdfsWithAuthenticationFilter |
| | hadoop.hdfs.tools.offlineImageViewer.TestOfflineImageViewerForXAttr |
| | hadoop.hdfs.TestBlockReaderFactory |
| | hadoop.hdfs.TestBlockReaderLocalLegacy |
| | hadoop.hdfs.server.datanode.TestDataDirs |
| | hadoop.hdfs.TestClose |
| | hadoop.hdfs.TestFetchImage |
| | hadoop.hdfs.TestDataTransferKeepalive |
| | hadoop.hdfs.TestDatanodeLayoutUpgrade |
| | hadoop.hdfs.TestPersistBlocks |
| | hadoop.hdfs.TestBlockMissingException |
| | hadoop.hdfs.server.blockmanagement.TestUnderReplicatedBlocks |
| | hadoop.hdfs.TestHDFSTrash |
| | hadoop.hdfs.tools.TestGetGroups |
| | hadoop.hdfs.TestPread |
| | hadoop.hdfs.TestFileCreationEmpty |
| | hadoop.hdfs.TestFileCreationDelete |
| | hadoop.hdfs.TestDatanodeStartupFixesLegacyStorageIDs |
| | hadoop.hdfs.server.datanode.TestNNHandlesBlockReportPerStorage |
| | hadoop.hdfs.TestListFilesInDFS |
| | hadoop.hdfs.TestReplaceDatanodeOnFailure |
| | hadoop.hdfs.TestDatanodeConfig |
| | hadoop.hdfs.TestEncryptionZonesWithHA |
| | hadoop.hdfs.shortcircuit.TestShortCircuitLocalRead |
| | hadoop.hdfs.server.balancer.TestBalancerWithEncryptedTransfer |
| | hadoop.hdfs.server.balancer.TestBalancer |
| | hadoop.hdfs.TestDFSStorageStateRecovery |
| | hadoop.hdfs.server.blockmanagement.TestBlockStatsMXBean |
| | hadoop.hdfs.TestDFSUpgradeFromImage |
| | hadoop.hdfs.TestDisableConnCache |
| | hadoop.hdfs.TestParallelRead |
| | hadoop.hdfs.server.blockmanagement.TestNameNodePrunesMissingStorages |
| | hadoop.hdfs.tools.TestDelegationTokenFetcher |
| | hadoop.hdfs.server.blockmanagement.TestBlockTokenWithDFS |
| | hadoop.hdfs.TestPipelines |
| | hadoop.hdfs.TestCrcCorruption |
| | hadoop.hdfs.TestDFSClientFailover |
| | hadoop.hdfs.security.token.block.TestBlockToken |
| | hadoop.hdfs.TestClientBlockVerification |
| | hadoop.hdfs.TestDFSClientExcludedNodes |
| | hadoop.hdfs.TestMultiThreadedHflush |
| | hadoop.hdfs.TestParallelShortCircuitReadUnCached |
| | hadoop.hdfs.server.datanode.TestDatanodeStartupOptions |
| | hadoop.hdfs.TestFileLengthOnClusterRestart |
| | hadoop.hdfs.TestMiniDFSCluster |
| | hadoop.hdfs.TestFileConcurrentReader |
| | hadoop.hdfs.TestDFSOutputStream |
| | hadoop.hdfs.TestDFSInputStream |
| | hadoop.hdfs.TestDFSMkdirs |
| | hadoop.hdfs.TestDecommission |
| | hadoop.hdfs.server.blockmanagement.TestSequentialBlockId |
| | hadoop.hdfs.TestListFilesInFileContext |
| | hadoop.hdfs.qjournal.TestNNWithQJM |
| | hadoop.hdfs.protocol.datatransfer.sasl.TestSaslDataTransfer |
| | hadoop.hdfs.TestEncryptionZones |
| | hadoop.hdfs.TestRollingUpgrade |
| | hadoop.hdfs.TestGetBlocks |
| | hadoop.hdfs.TestRestartDFS |
| | hadoop.hdfs.TestDFSStartupVersions |
| | hadoop.hdfs.TestDFSRollback |
| | hadoop.hdfs.TestWriteBlockGetsBlockLengthHint |
| | hadoop.hdfs.TestDataTransferProtocol |
| | hadoop.hdfs.shortcircuit.TestShortCircuitCache |
| | hadoop.hdfs.TestRollingUpgradeDowngrade |
| | hadoop.hdfs.tools.offlineEditsViewer.TestOfflineEditsViewer |
| | hadoop.hdfs.TestDFSPermission |
| | hadoop.hdfs.TestDatanodeReport |
| | hadoop.hdfs.server.datanode.TestDataNodeRollingUpgrade |
| | hadoop.hdfs.TestDFSAddressConfig |
| | hadoop.hdfs.TestExternalBlockReader |
| | hadoop.hdfs.server.balancer.TestBalancerWithSaslDataTransfer |
| | hadoop.hdfs.tools.TestStoragePolicyCommands |
| | hadoop.hdfs.security.TestDelegationToken |
| | hadoop.hdfs.TestBlockStoragePolicy |
| | hadoop.hdfs.TestInjectionForSimulatedStorage |
| | hadoop.hdfs.TestFileAppendRestart |
| | hadoop.hdfs.TestConnCache |
| | hadoop.hdfs.TestRollingUpgradeRollback |
| | hadoop.hdfs.TestEncryptedTransfer |
| | hadoop.hdfs.TestDatanodeRegistration |
| | hadoop.hdfs.server.blockmanagement.TestHeartbeatHandling |
| | hadoop.hdfs.TestFileAppend3 |
| | hadoop.hdfs.TestBalancerBandwidth |
| | hadoop.hdfs.server.blockmanagement.TestPendingInvalidateBlock |
| | hadoop.hdfs.TestDFSRemove |
| | hadoop.hdfs.TestDistributedFileSystem |
| | hadoop.hdfs.TestSetrepDecreasing |
| | hadoop.hdfs.TestFSInputChecker |
| | hadoop.hdfs.server.blockmanagement.TestOverReplicatedBlocks |
| | hadoop.hdfs.TestAppendSnapshotTruncate |
| | hadoop.hdfs.tools.offlineImageViewer.TestOfflineImageViewer |
| | hadoop.hdfs.TestFsShellPermission |
| | hadoop.hdfs.web.TestWebHDFSXAttr |
| | hadoop.hdfs.TestGetFileChecksum |
| | hadoop.hdfs.TestLeaseRecovery |
| | hadoop.hdfs.web.TestWebHDFSAcl |
| | hadoop.hdfs.server.datanode.TestDataNodeFSDataSetSink |
| | hadoop.hdfs.client.impl.TestLeaseRenewer |
| | hadoop.hdfs.TestParallelShortCircuitLegacyRead |
| | hadoop.hdfs.server.datanode.TestDataNodeInitStorage |
| | hadoop.hdfs.TestFileStatus |
| | hadoop.hdfs.TestLeaseRecovery2 |
| | hadoop.hdfs.server.blockmanagement.TestBlockReportRateLimiting |
| | hadoop.hdfs.TestDFSUpgrade |
| | hadoop.hdfs.web.TestWebHDFSForHA |
| | hadoop.hdfs.server.mover.TestMover |
| | hadoop.hdfs.TestParallelUnixDomainRead |
| | hadoop.hdfs.security.TestDelegationTokenForProxyUser |
| | hadoop.hdfs.server.blockmanagement.TestReplicationPolicy |
| | hadoop.hdfs.TestParallelShortCircuitRead |
| | hadoop.hdfs.server.datanode.TestDataXceiverLazyPersistHint |
| | hadoop.hdfs.server.balancer.TestBalancerWithMultipleNameNodes |
| | hadoop.hdfs.TestSeekBug |
\\
\\
|| Subsystem || Report/Notes ||
| Patch URL |
http://issues.apache.org/jira/secure/attachment/12753838/HDFS-9002.001.patch |
| Optional Tests | javadoc javac unit findbugs checkstyle |
| git revision | trunk / c006c3a |
| javadoc |
https://builds.apache.org/job/PreCommit-HDFS-Build/12255/artifact/patchprocess/diffJavadocWarnings.txt
|
| checkstyle |
https://builds.apache.org/job/PreCommit-HDFS-Build/12255/artifact/patchprocess/diffcheckstylehadoop-hdfs-client.txt
|
| Findbugs warnings |
https://builds.apache.org/job/PreCommit-HDFS-Build/12255/artifact/patchprocess/newPatchFindbugsWarningshadoop-hdfs-client.html
|
| hadoop-hdfs test log |
https://builds.apache.org/job/PreCommit-HDFS-Build/12255/artifact/patchprocess/testrun_hadoop-hdfs.txt
|
| hadoop-hdfs-client test log |
https://builds.apache.org/job/PreCommit-HDFS-Build/12255/artifact/patchprocess/testrun_hadoop-hdfs-client.txt
|
| Test Results |
https://builds.apache.org/job/PreCommit-HDFS-Build/12255/testReport/ |
| Java | 1.7.0_55 |
| uname | Linux asf905.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP
PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux |
| Console output |
https://builds.apache.org/job/PreCommit-HDFS-Build/12255/console |
This message was automatically generated.
> Move o.a.h.hdfs.net/*Peer classes to client module
> --------------------------------------------------
>
> Key: HDFS-9002
> URL: https://issues.apache.org/jira/browse/HDFS-9002
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: build
> Reporter: Mingliang Liu
> Assignee: Mingliang Liu
> Attachments: HDFS-9002.000.patch, HDFS-9002.001.patch
>
>
> This jira tracks the effort of moving the following two parts to
> {{hadoop-hdfs-client}} module:
> * {{*Peer.java}} classes
> * static helper methods in {{TcpPeerServer}}
> In {{org.apache.hadoop.hdfs.net}} package, the {{Peer}} classes should be
> moved to {{hadoop-hdfs-client}} module as they are used in client, while
> {{PeerServer}} classes stay in {{hadoop-hdfs}} module. For the static helper
> methods in {{TcpPeerServer}}, we need to move them out of the
> {{TcpPeerServer}} class and put them in client module.
> Meanwhile, we need to move the related classes in
> {{org.apache.hadoop.hdfs.protocol.datatransfer.sasl}} packages as they're
> used by client module. Config keys should also be moved.
> The checkstyle warnings can be addressed in [HDFS-8979 |
> https://issues.apache.org/jira/browse/HDFS-8979], and removing the _slf4j_
> logger guards when calling {{LOG.debug()}} and {{LOG.trace()}} can be
> addressed in [HDFS-8971 | https://issues.apache.org/jira/browse/HDFS-8971].
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
