[
https://issues.apache.org/jira/browse/HDFS-9002?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14729864#comment-14729864
]
Hadoop QA commented on HDFS-9002:
---------------------------------
\\
\\
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:red}-1{color} | pre-patch | 17m 39s | Findbugs (version 3.0.0)
appears to be broken on trunk. |
| {color:green}+1{color} | @author | 0m 0s | The patch does not contain any
@author tags. |
| {color:green}+1{color} | tests included | 0m 0s | The patch appears to
include 8 new or modified test files. |
| {color:green}+1{color} | javac | 7m 56s | There were no new javac warning
messages. |
| {color:green}+1{color} | javadoc | 10m 5s | There were no new javadoc
warning messages. |
| {color:green}+1{color} | release audit | 0m 23s | The applied patch does
not increase the total number of release audit warnings. |
| {color:green}+1{color} | checkstyle | 1m 34s | There were no new checkstyle
issues. |
| {color:green}+1{color} | whitespace | 0m 5s | The patch has no lines that
end in whitespace. |
| {color:green}+1{color} | install | 1m 36s | mvn install still works. |
| {color:green}+1{color} | eclipse:eclipse | 0m 32s | The patch built with
eclipse:eclipse. |
| {color:green}+1{color} | findbugs | 4m 26s | The patch does not introduce
any new Findbugs (version 3.0.0) warnings. |
| {color:green}+1{color} | native | 3m 12s | Pre-build of native portion |
| {color:green}+1{color} | hdfs tests | 163m 6s | Tests passed in hadoop-hdfs.
|
| {color:green}+1{color} | hdfs tests | 0m 29s | Tests passed in
hadoop-hdfs-client. |
| | | 211m 8s | |
\\
\\
|| Subsystem || Report/Notes ||
| Patch URL |
http://issues.apache.org/jira/secure/attachment/12754048/HDFS-9002.003.patch |
| Optional Tests | javadoc javac unit findbugs checkstyle |
| git revision | trunk / 524ba87 |
| hadoop-hdfs test log |
https://builds.apache.org/job/PreCommit-HDFS-Build/12289/artifact/patchprocess/testrun_hadoop-hdfs.txt
|
| hadoop-hdfs-client test log |
https://builds.apache.org/job/PreCommit-HDFS-Build/12289/artifact/patchprocess/testrun_hadoop-hdfs-client.txt
|
| Test Results |
https://builds.apache.org/job/PreCommit-HDFS-Build/12289/testReport/ |
| Java | 1.7.0_55 |
| uname | Linux asf905.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP
PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux |
| Console output |
https://builds.apache.org/job/PreCommit-HDFS-Build/12289/console |
This message was automatically generated.
> Move o.a.h.hdfs.net/*Peer classes to client module
> --------------------------------------------------
>
> Key: HDFS-9002
> URL: https://issues.apache.org/jira/browse/HDFS-9002
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: build
> Reporter: Mingliang Liu
> Assignee: Mingliang Liu
> Attachments: HDFS-9002.000.patch, HDFS-9002.001.patch,
> HDFS-9002.002.patch, HDFS-9002.003.patch
>
>
> This jira tracks the effort of moving the following two parts to
> {{hadoop-hdfs-client}} module:
> * {{*Peer.java}} classes
> * static helper methods in {{TcpPeerServer}}
> In {{org.apache.hadoop.hdfs.net}} package, the {{Peer}} classes should be
> moved to {{hadoop-hdfs-client}} module as they are used in client, while
> {{PeerServer}} classes stay in {{hadoop-hdfs}} module. For the static helper
> methods in {{TcpPeerServer}}, we need to move them out of the
> {{TcpPeerServer}} class and put them in client module.
> Meanwhile, we need to move the related classes in
> {{org.apache.hadoop.hdfs.protocol.datatransfer.sasl}} packages as they're
> used by client module. Config keys should also be moved.
> The checkstyle warnings can be addressed in [HDFS-8979 |
> https://issues.apache.org/jira/browse/HDFS-8979], and removing the _slf4j_
> logger guards when calling {{LOG.debug()}} and {{LOG.trace()}} can be
> addressed in [HDFS-8971 | https://issues.apache.org/jira/browse/HDFS-8971].
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
