[
https://issues.apache.org/jira/browse/HDFS-6955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14741256#comment-14741256
]
Arpit Agarwal commented on HDFS-6955:
-------------------------------------
Thanks for updating the patch. A few comments.
# Nitpick: Please add spaces around operators {{replicaInfo!=null}}
# It doesn't look like there is a new test case for temporary reservation. We
should have test case for both full and interrupted transfer.
# {{FsVolumeImpl#recentReserved}} looks unused. Let's remove it.
# I didn't recall the state machine, do temporary blocks get finalized?
> DN should reserve disk space for a full block when creating tmp files
> ---------------------------------------------------------------------
>
> Key: HDFS-6955
> URL: https://issues.apache.org/jira/browse/HDFS-6955
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: datanode
> Affects Versions: 2.5.0
> Reporter: Arpit Agarwal
> Assignee: Kanaka Kumar Avvaru
> Attachments: HDFS-6955-01.patch, HDFS-6955-02.patch,
> HDFS-6955-03.patch, HDFS-6955-04.patch, HDFS-6955-05.patch,
> HDFS-6955-06.patch, HDFS-6955-07.patch
>
>
> HDFS-6898 is introducing disk space reservation for RBW files to avoid
> running out of disk space midway through block creation.
> This Jira is to introduce similar reservation for tmp files.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
