[
https://issues.apache.org/jira/browse/HDFS-9112?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14904828#comment-14904828
]
Anu Engineer commented on HDFS-9112:
------------------------------------
[~templedf] Thank you very much for your code review and comments.
Before we begin, I want to point out that [~jingzhao] commented that we should
*not* fix this issue at all, but just add a warning for the user that they
should use "-ns" option in the error message.This is based on the discussion in
HDFS-6376. So I have a second patch which does exactly that. So I am guessing
that second patch will get applied by [~jingzhao].
Meanwhile I will post one more patch that modifies the first code path in case
you would like to use it.
bq. Love that you're explaining what you're doing, but let's leave the JIRA ID
out of it and don't explain it in terms of what changed. The comment should
just explain the current state of things.
Agreed, let me remove the redundant JIRA number and fix that comment.
bq. internalNSIds.iterator().next()
It might be, however I was just following the pattern in the nearby code. It is
easier to read code if we have same patterns in a file.
bq. I really don't like the idea of duplicating key names between DFSConfigKeys
and HdfsClientConfigKeys
Not really sure about this, but I am guessing this might be due to the fact
that we have an on-going refactoring work being done which separates HDFS
client into its own jar.
> Haadmin fails if multiple name service IDs are configured
> ---------------------------------------------------------
>
> Key: HDFS-9112
> URL: https://issues.apache.org/jira/browse/HDFS-9112
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: tools
> Affects Versions: 2.7.1
> Reporter: Anu Engineer
> Assignee: Anu Engineer
> Attachments: HDFS-9112.001.patch, HDFS-9112.002.patch
>
>
> In HDFS-6376 we supported a feature for distcp that allows multiple
> NameService IDs to be specified so that we can copy from two HA enabled
> clusters.
> That confuses haadmin command since we have a check in
> DFSUtil#getNamenodeServiceAddr which fails if it finds more than 1 name in
> that property.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
