[
https://issues.apache.org/jira/browse/HDFS-9112?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14908307#comment-14908307
]
Daniel Templeton commented on HDFS-9112:
----------------------------------------
Thanks, [~anu]. Good error message! If you don't mind, I'd like to suggest
some minor changes:
bq. "Unable to determine the nameservice id. This is an HA configuration with
multiple Name services configured. " + DFS_NAMESERVICES + " value is set to " +
Arrays.toString(dfsNames) + ". Please re-run with -ns option."
I would prefer:
{code}
"Unable to determine the name service ID. This is an HA configuration with
multiple name services configured. " + DFS_NAMESERVICES + " is set to " +
Arrays.toString(dfsNames) + ". Please re-run with the -ns option."
{code}
Sorry to play language police. :)
I would also rather see some use of newlines to make the code a little more
readable. I like to see a newline on either side of a code block, so, in this
case, before each of the if statements and after the closing braces. I'll +1
one the patch (after the language changes) without newlines, but I think it
would be swell to add some.
> Haadmin fails if multiple name service IDs are configured
> ---------------------------------------------------------
>
> Key: HDFS-9112
> URL: https://issues.apache.org/jira/browse/HDFS-9112
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: tools
> Affects Versions: 2.7.1
> Reporter: Anu Engineer
> Assignee: Anu Engineer
> Attachments: HDFS-9112.001.patch, HDFS-9112.002.patch,
> HDFS-9112.003.patch
>
>
> In HDFS-6376 we supported a feature for distcp that allows multiple
> NameService IDs to be specified so that we can copy from two HA enabled
> clusters.
> That confuses haadmin command since we have a check in
> DFSUtil#getNamenodeServiceAddr which fails if it finds more than 1 name in
> that property.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
