[ 
https://issues.apache.org/jira/browse/HDFS-8053?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14905203#comment-14905203
 ] 

Mingliang Liu commented on HDFS-8053:
-------------------------------------

In the {{DFSClient$Renewer}}, there is a code piece like:
{code}
    static {
      //Ensure that HDFS Configuration files are loaded before trying to use
      // the renewer.
      HdfsConfiguration.init();
    }
{code}
Its purpose was elaborated in [HDFS-3012]. Specifically, there may be an 
exception while renewing delegation token, because:
{quote}
...the RM has no direct reference to HDFS at all. The DFSClient.Renewer is 
loaded using a ServiceLoader and there is no reference to HdfsConfiguration 
from DFSClient.Renewer.
{quote}


This code section was deleted in the v0 patch (commented as _TODO_). The reason 
was that the {{HdfsConfiguration}} is in {{hadoop-hdfs}} module and it should 
be. I had a look at the code and I think we may still need to keep this code as 
it-is.

A possbile solution is to move the {{DFSClient$Renewer}} class out of the 
{{DFSClient}} class and put it in the {{hadoop-hdfs}} module.

> Move DFSIn/OutputStream and related classes to hadoop-hdfs-client
> -----------------------------------------------------------------
>
>                 Key: HDFS-8053
>                 URL: https://issues.apache.org/jira/browse/HDFS-8053
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: build
>            Reporter: Haohui Mai
>            Assignee: Mingliang Liu
>         Attachments: HDFS-8053.000.patch
>
>
> This jira tracks the effort of moving the {{DFSInputStream}} and 
> {{DFSOutputSream}} classes from {{hadoop-hdfs}} to {{hadoop-hdfs-client}} 
> module.
> Guidelines:
> * As the {{DFSClient}} is heavily coupled to these two classes, we should 
> move it together.
> * Related classes should be addressed in separate jiras if they're 
> independent and complex enough.
> * The checkstyle warnings can be addressed in [HDFS-8979 | 
> https://issues.apache.org/jira/browse/HDFS-8979]
> * Removing the _slf4j_ logger guards when calling {{LOG.debug()}} and 
> {{LOG.trace()}} can be addressed in [HDFS-8971 | 
> https://issues.apache.org/jira/browse/HDFS-8971].



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to