[
https://issues.apache.org/jira/browse/HDFS-8053?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14905260#comment-14905260
]
Haohui Mai commented on HDFS-8053:
----------------------------------
Thanks for the work. On a high level it makes sense to separate the patch to
multiple jiras.
{code}
- ((Log4JLogger) NameNode.stateChangeLog).getLogger().setLevel(Level.ALL);
- ((Log4JLogger)
LogFactory.getLog(FSNamesystem.class)).getLogger().setLevel(Level.ALL);
- ((Log4JLogger) DataNode.LOG).getLogger().setLevel(Level.ALL);
- ((Log4JLogger) TestFiPipelines.LOG).getLogger().setLevel(Level.ALL);
- ((Log4JLogger) DFSClient.LOG).getLogger().setLevel(Level.ALL);
- ((Log4JLogger) FiTestUtil.LOG).getLogger().setLevel(Level.ALL);
- ((Log4JLogger) BlockReceiverAspects.LOG).getLogger().setLevel(Level.ALL);
- ((Log4JLogger) DFSClientAspects.LOG).getLogger().setLevel(Level.ALL);
+ GenericTestUtils.setLogLevel(NameNode.stateChangeLog, Level.ALL);
+ GenericTestUtils.setLogLevel(FSNamesystem.LOG, Level.ALL);
+ GenericTestUtils.setLogLevel(DataNode.LOG, Level.ALL);
+ GenericTestUtils.setLogLevel(TestFiPipelines.LOG, Level.ALL);
+ GenericTestUtils.setLogLevel(DFSClient.LOG, Level.ALL);
+ GenericTestUtils.setLogLevel(FiTestUtil.LOG, Level.ALL);
+ GenericTestUtils.setLogLevel(BlockReceiverAspects.LOG, Level.ALL);
+ GenericTestUtils.setLogLevel(DFSClientAspects.LOG, Level.ALL);
{code}
It makes sense to have a separate jira to go through the codebase of hdfs and
to do above change.
{code}
- IOUtils.cleanup(LOG, peer);
+ IOUtilsClient.cleanup(LOG, peer);
{code}
These changes can be separated into a separate jira, and in that jira it should
look into whether it is possible to use the try-with-resource statement in Java
7.
{code}
- SpanReceiverHost.get(conf, DFSConfigKeys.DFS_CLIENT_HTRACE_PREFIX);
+ SpanReceiverHost.get(conf, HdfsClientConfigKeys.DFS_CLIENT_HTRACE_PREFIX);
{code}
All these changes of configuration keys should be in a separate jira.
> Move DFSIn/OutputStream and related classes to hadoop-hdfs-client
> -----------------------------------------------------------------
>
> Key: HDFS-8053
> URL: https://issues.apache.org/jira/browse/HDFS-8053
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: build
> Reporter: Haohui Mai
> Assignee: Mingliang Liu
> Attachments: HDFS-8053.000.patch
>
>
> This jira tracks the effort of moving the {{DFSInputStream}} and
> {{DFSOutputSream}} classes from {{hadoop-hdfs}} to {{hadoop-hdfs-client}}
> module.
> Guidelines:
> * As the {{DFSClient}} is heavily coupled to these two classes, we should
> move it together.
> * Related classes should be addressed in separate jiras if they're
> independent and complex enough.
> * The checkstyle warnings can be addressed in [HDFS-8979 |
> https://issues.apache.org/jira/browse/HDFS-8979]
> * Removing the _slf4j_ logger guards when calling {{LOG.debug()}} and
> {{LOG.trace()}} can be addressed in [HDFS-8971 |
> https://issues.apache.org/jira/browse/HDFS-8971].
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
