[
https://issues.apache.org/jira/browse/HDFS-7529?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14905215#comment-14905215
]
Haohui Mai commented on HDFS-7529:
----------------------------------
Thanks for taking the work! It looks good overall.
{code}
+ static EncryptedKeyVersion generateEncryptedDataEncryptionKey(final
FSNamesystem fsn, final String ezKeyName) throws IOException {
{code}
{{FSDirEncryptionZoneOp.java}} should minimize the usage of {{FSNamesystem}}.
Most of the functions in the current patch are passing in {{FSNamesystem}}
instead of {{FSDirectory}}. It's better to clean them up. The changes includes:
* Remove the assertion on holding the FSNamesystem lock
* Introduce a new getting method in FSDirectory to get the
{{KeyProviderCryptoExtension}} object, or just move it inside {{FSDirectory}}.
> Consolidate encryption zone related implementation into a single class
> ----------------------------------------------------------------------
>
> Key: HDFS-7529
> URL: https://issues.apache.org/jira/browse/HDFS-7529
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Reporter: Haohui Mai
> Assignee: Rakesh R
> Attachments: HDFS-7529-002.patch, HDFS-7529-003.patch,
> HDFS-7529-004.patch, HDFS-7529.000.patch, HDFS-7529.001.patch
>
>
> This jira proposes to consolidate encryption zone related implementation to a
> single class.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
