[
https://issues.apache.org/jira/browse/HDFS-9110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14948824#comment-14948824
]
Hadoop QA commented on HDFS-9110:
---------------------------------
\\
\\
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:red}-1{color} | patch | 0m 0s | The patch command could not apply
the patch during dryrun. |
\\
\\
|| Subsystem || Report/Notes ||
| Patch URL |
http://issues.apache.org/jira/secure/attachment/12765615/HDFS-9110.06.patch |
| Optional Tests | javadoc javac unit findbugs checkstyle |
| git revision | trunk / 1107bd3 |
| Console output |
https://builds.apache.org/job/PreCommit-HDFS-Build/12866/console |
This message was automatically generated.
> Use Files.walkFileTree in NNUpgradeUtil#doPreUpgrade for better efficiency
> --------------------------------------------------------------------------
>
> Key: HDFS-9110
> URL: https://issues.apache.org/jira/browse/HDFS-9110
> Project: Hadoop HDFS
> Issue Type: Improvement
> Affects Versions: 2.7.0
> Reporter: Charlie Helin
> Assignee: Charlie Helin
> Priority: Minor
> Attachments: HDFS-9110.00.patch, HDFS-9110.01.patch,
> HDFS-9110.02.patch, HDFS-9110.03.patch, HDFS-9110.04.patch,
> HDFS-9110.05.patch, HDFS-9110.06.patch
>
>
> This is a request to do some cosmetic improvements on top of HDFS-8480. There
> a couple of File -> java.nio.file.Path conversions which is a little bit
> distracting.
> The second aspect is more around efficiency, to be perfectly honest I'm not
> sure what the number of files that may be processed. However as HDFS-8480
> eludes to it appears that this number could be significantly large.
> The current implementation is basically a collect and process where all files
> first is being examined; put into a collection and after that processed.
> HDFS-8480 could simply be further enhanced by employing a single iteration
> without creating an intermediary collection of filenames by using a FileWalker
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
