[
https://issues.apache.org/jira/browse/HDFS-9110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14950899#comment-14950899
]
Hadoop QA commented on HDFS-9110:
---------------------------------
\\
\\
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | pre-patch | 20m 32s | Pre-patch trunk compilation is
healthy. |
| {color:green}+1{color} | @author | 0m 0s | The patch does not contain any
@author tags. |
| {color:red}-1{color} | tests included | 0m 0s | The patch doesn't appear
to include any new or modified tests. Please justify why no new tests are
needed for this patch. Also please list what manual steps were performed to
verify this patch. |
| {color:green}+1{color} | javac | 9m 7s | There were no new javac warning
messages. |
| {color:green}+1{color} | javadoc | 11m 43s | There were no new javadoc
warning messages. |
| {color:red}-1{color} | release audit | 0m 21s | The applied patch generated
1 release audit warnings. |
| {color:green}+1{color} | checkstyle | 1m 31s | There were no new checkstyle
issues. |
| {color:green}+1{color} | whitespace | 0m 0s | The patch has no lines that
end in whitespace. |
| {color:green}+1{color} | install | 1m 41s | mvn install still works. |
| {color:green}+1{color} | eclipse:eclipse | 0m 37s | The patch built with
eclipse:eclipse. |
| {color:green}+1{color} | findbugs | 3m 12s | The patch does not introduce
any new Findbugs (version 3.0.0) warnings. |
| {color:green}+1{color} | native | 4m 44s | Pre-build of native portion |
| {color:red}-1{color} | hdfs tests | 178m 45s | Tests failed in hadoop-hdfs. |
| | | 232m 17s | |
\\
\\
|| Reason || Tests ||
| Failed unit tests | hadoop.hdfs.server.namenode.ha.TestStandbyCheckpoints |
| Timed out tests | org.apache.hadoop.hdfs.server.namenode.TestDeadDatanode |
| | org.apache.hadoop.hdfs.TestBlockReaderFactory |
| | org.apache.hadoop.hdfs.server.namenode.TestMalformedURLs |
\\
\\
|| Subsystem || Report/Notes ||
| Patch URL |
http://issues.apache.org/jira/secure/attachment/12765673/HDFS-9110.08.patch |
| Optional Tests | javadoc javac unit findbugs checkstyle |
| git revision | trunk / 8f19538 |
| Release Audit |
https://builds.apache.org/job/PreCommit-HDFS-Build/12891/artifact/patchprocess/patchReleaseAuditProblems.txt
|
| hadoop-hdfs test log |
https://builds.apache.org/job/PreCommit-HDFS-Build/12891/artifact/patchprocess/testrun_hadoop-hdfs.txt
|
| Test Results |
https://builds.apache.org/job/PreCommit-HDFS-Build/12891/testReport/ |
| Java | 1.7.0_55 |
| uname | Linux asf909.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP
PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux |
| Console output |
https://builds.apache.org/job/PreCommit-HDFS-Build/12891/console |
This message was automatically generated.
> Use Files.walkFileTree in NNUpgradeUtil#doPreUpgrade for better efficiency
> --------------------------------------------------------------------------
>
> Key: HDFS-9110
> URL: https://issues.apache.org/jira/browse/HDFS-9110
> Project: Hadoop HDFS
> Issue Type: Improvement
> Affects Versions: 2.7.0
> Reporter: Charlie Helin
> Assignee: Charlie Helin
> Priority: Minor
> Attachments: HDFS-9110.00.patch, HDFS-9110.01.patch,
> HDFS-9110.02.patch, HDFS-9110.03.patch, HDFS-9110.04.patch,
> HDFS-9110.05.patch, HDFS-9110.06.patch, HDFS-9110.07.patch, HDFS-9110.08.patch
>
>
> This is a request to do some cosmetic improvements on top of HDFS-8480. There
> a couple of File -> java.nio.file.Path conversions which is a little bit
> distracting.
> The second aspect is more around efficiency, to be perfectly honest I'm not
> sure what the number of files that may be processed. However as HDFS-8480
> eludes to it appears that this number could be significantly large.
> The current implementation is basically a collect and process where all files
> first is being examined; put into a collection and after that processed.
> HDFS-8480 could simply be further enhanced by employing a single iteration
> without creating an intermediary collection of filenames by using a FileWalker
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
