[ 
https://issues.apache.org/jira/browse/HDFS-7087?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14951451#comment-14951451
 ] 

Andrew Wang commented on HDFS-7087:
-----------------------------------

Hi Xiao, thanks for working on this! Some review comments:

* Would appreciate javadoc and comments explaining the new methods, and also 
rationale for the new fake FileStatuses.
* Any reason you set the sticky bit?
* The isExactReservedName checks, noticed there's no check for rename. This 
seems brittle in general since we have to make sure it's present in everything 
besides list. Is the intent of these checks to provide consistent behavior? Do 
we think this is necessary, or can we simply rely on the existing behavior?
* This enables listing /.reserved/raw/.reserved/, which is a little weird.
* There are some acrobatics to get the cTime. Is this something we could set 
during FSImage loading? Would let us avoid the null check.

> Ability to list /.reserved
> --------------------------
>
>                 Key: HDFS-7087
>                 URL: https://issues.apache.org/jira/browse/HDFS-7087
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>    Affects Versions: 2.6.0
>            Reporter: Andrew Wang
>            Assignee: Xiao Chen
>         Attachments: HDFS-7087.001.patch, HDFS-7087.draft.patch
>
>
> We have two special paths within /.reserved now, /.reserved/.inodes and 
> /.reserved/raw. It seems like we should be able to list /.reserved to see 
> them.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to