[
https://issues.apache.org/jira/browse/HDFS-7087?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14964261#comment-14964261
]
Andrew Wang commented on HDFS-7087:
-----------------------------------
Looks good, thanks for revving Xiao. Patch needs a small rebase for
TestDFSShell. Only two little nits:
* FSNamesystem.getCTime is marked VisibleForTesting. What we could do is pass
the cTime as a parameter to createReservedStatuses which decouples FSN and
FSDir a bit more. Also would be good to add something to createReservedStatuses
javadoc about how this is called only once during NN initialization.
* Add a Precondition check that reservedStatuses is not null before use? Maybe
in getReservedStatuses. This also serves as documentation that
createReservedStatuses should be called first.
> Ability to list /.reserved
> --------------------------
>
> Key: HDFS-7087
> URL: https://issues.apache.org/jira/browse/HDFS-7087
> Project: Hadoop HDFS
> Issue Type: Improvement
> Affects Versions: 2.6.0
> Reporter: Andrew Wang
> Assignee: Xiao Chen
> Attachments: HDFS-7087.001.patch, HDFS-7087.002.patch,
> HDFS-7087.draft.patch
>
>
> We have two special paths within /.reserved now, /.reserved/.inodes and
> /.reserved/raw. It seems like we should be able to list /.reserved to see
> them.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
