[
https://issues.apache.org/jira/browse/HDFS-9117?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14967395#comment-14967395
]
James Clampffer commented on HDFS-9117:
---------------------------------------
Some Feedback:
More comments would be nice, particularly about how
Configuration::SubstituteVars works at a high level.
Is an empty string sufficient to indicate failure for get_homedir() and
get_username()? Maybe add a comment making that explicit.
I think file_exists should do a S_IFREG(buffer.st_mode) to make sure it's a
regular file. Otherwise it's possible for Configuration::AddFileResource to
fail before checking all search paths if the absolute path turns out to be a
directory as unlikely as that may be.
Should str_to_bool trim left and right whitespace? Not sure if the xml parser
handles that.
Otherwise it looks good to me.
> Config file reader / options classes for libhdfs++
> --------------------------------------------------
>
> Key: HDFS-9117
> URL: https://issues.apache.org/jira/browse/HDFS-9117
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: hdfs-client
> Affects Versions: HDFS-8707
> Reporter: Bob Hansen
> Assignee: Bob Hansen
> Attachments: HDFS-9117.HDFS-8707.001.patch,
> HDFS-9117.HDFS-8707.002.patch, HDFS-9117.HDFS-8707.003.patch,
> HDFS-9117.HDFS-8707.004.patch
>
>
> For environmental compatability with HDFS installations, libhdfs++ should be
> able to read the configurations from Hadoop XML files and behave in line with
> the Java implementation.
> Most notably, machine names and ports should be readable from Hadoop XML
> configuration files.
> Similarly, an internal Options architecture for libhdfs++ should be developed
> to efficiently transport the configuration information within the system.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
