[ 
https://issues.apache.org/jira/browse/HDFS-9255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14977111#comment-14977111
 ] 

Zhe Zhang commented on HDFS-9255:
---------------------------------

Thanks Walter for the update. +1 on the latest patch (listing a few nits that 
can be done as follow-on). [~jingzhao] Do you have further comments?
# {{BlockRecoveryWorker#recoverBlocks}} doesn't need a return value
# Even though DN now initializes the recovery worker before block pool manager, 
{{BPOfferService}} can still use a null check at {{dn.getBlockRecoveryWorker()}}

> Consolidate block recovery related implementation into a single class
> ---------------------------------------------------------------------
>
>                 Key: HDFS-9255
>                 URL: https://issues.apache.org/jira/browse/HDFS-9255
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: datanode
>            Reporter: Walter Su
>            Assignee: Walter Su
>            Priority: Minor
>         Attachments: HDFS-9255.01.patch, HDFS-9255.02.patch, 
> HDFS-9255.03.patch, HDFS-9255.04.patch, HDFS-9255.05.patch, HDFS-9255.06.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to