[ 
https://issues.apache.org/jira/browse/HDFS-9255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14971591#comment-14971591
 ] 

Jing Zhao commented on HDFS-9255:
---------------------------------

Thanks for working on this, Walter! The patch looks pretty good to me. One 
question is: since {{DataNode#blockRecoveryWorker}} is not declared as final, 
can we make sure the BPServiceActor thread can always see its non-null value 
when calling {{getBlockRecoveryWorker}}?

> Consolidate block recovery related implementation into a single class
> ---------------------------------------------------------------------
>
>                 Key: HDFS-9255
>                 URL: https://issues.apache.org/jira/browse/HDFS-9255
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: datanode
>            Reporter: Walter Su
>            Assignee: Walter Su
>            Priority: Minor
>         Attachments: HDFS-9255.01.patch, HDFS-9255.02.patch, 
> HDFS-9255.03.patch, HDFS-9255.04.patch, HDFS-9255.05.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to