[
https://issues.apache.org/jira/browse/HDFS-8766?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14979012#comment-14979012
]
James Clampffer commented on HDFS-8766:
---------------------------------------
"Please wrap the statement with braces though it is a single line. There are
several places like the above code needs to be fixed."
It looks like this is something the google coding style explicitly allows:
"Short conditional statements may be written on one line if this enhances
readability. You may use this only when the line is brief and the statement
does not use the else clause.". If we are going to be very strict about those
rules everywhere else I'd like to keep them the same here. I don't feel
strongly about it either way but any exceptions or additional restrictions need
to be easily available for everyone to see. Even without any extra stuff we at
least need a README that says "all code must follow google's standards".
Currently the only way people can find out that this project sticks to the
google style guide is by reading all of the comments and even they will only
catch the additional rules that have been pointed out. This will save everyone
a significant amount of time because we'll have fewer code reviews fail due to
style issues.
If you have time today or tomorrow would you mind dropping a README into
/libhdfspp file with your coding standards? I'd be happy to add one but I
don't know what else I'd be missing. I'll file a jira for adding a file with
coding standards to the source tree.
Let me know what you prefer with the simple if..cond..something and I'll
conform to that. I'll get the debug helpers out of the header.
> Implement a libhdfs(3) compatible API
> -------------------------------------
>
> Key: HDFS-8766
> URL: https://issues.apache.org/jira/browse/HDFS-8766
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: hdfs-client
> Reporter: James Clampffer
> Assignee: James Clampffer
> Attachments: HDFS-8766.HDFS-8707.000.patch,
> HDFS-8766.HDFS-8707.001.patch, HDFS-8766.HDFS-8707.002.patch,
> HDFS-8766.HDFS-8707.003.patch, HDFS-8766.HDFS-8707.004.patch,
> HDFS-8766.HDFS-8707.005.patch, HDFS-8766.HDFS-8707.006.patch,
> HDFS-8766.HDFS-8707.007.patch, HDFS-8766.HDFS-8707.008.patch,
> HDFS-8766.HDFS-8707.009.patch, HDFS-8766.HDFS-8707.010.patch,
> HDFS-8766.HDFS-8707.011.patch
>
>
> Add a synchronous API that is compatible with the hdfs.h header used in
> libhdfs and libhdfs3. This will make it possible for projects using
> libhdfs/libhdfs3 to relink against libhdfspp with minimal changes.
> This also provides a pure C interface that can be linked against projects
> that aren't built in C++11 mode for various reasons but use the same
> compiler. It also allows many other programming languages to access
> libhdfspp through builtin FFI interfaces.
> The libhdfs API is very similar to the posix file API which makes it easier
> for programs built using posix filesystem calls to be modified to access HDFS.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
