[
https://issues.apache.org/jira/browse/HDFS-9038?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15014806#comment-15014806
]
Chris Nauroth commented on HDFS-9038:
-------------------------------------
[~brahmareddy], thank you for the patch. This looks pretty good to me, though
I'd also appreciate a second code review, maybe from [~vinayrpet] or
[~arpitagarwal].
I just have one point of feedback right now. In
{{DatanodeStorageInfo#toStorageReport}}, should the call to the
{{StorageReport}} constructor pass along {{nonDfsUsed}} instead of hard-coding
{{0L}}?
After that's addressed, I'll put this through some manual testing too.
> Reserved space is erroneously counted towards non-DFS used.
> -----------------------------------------------------------
>
> Key: HDFS-9038
> URL: https://issues.apache.org/jira/browse/HDFS-9038
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: datanode
> Affects Versions: 2.7.1
> Reporter: Chris Nauroth
> Assignee: Brahma Reddy Battula
> Attachments: HDFS-9038-002.patch, HDFS-9038.patch
>
>
> HDFS-5215 changed the DataNode volume available space calculation to consider
> the reserved space held by the {{dfs.datanode.du.reserved}} configuration
> property. As a side effect, reserved space is now counted towards non-DFS
> used. I don't believe it was intentional to change the definition of non-DFS
> used. This issue proposes restoring the prior behavior: do not count
> reserved space towards non-DFS used.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
