[
https://issues.apache.org/jira/browse/HDFS-9429?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15025752#comment-15025752
]
Zhe Zhang commented on HDFS-9429:
---------------------------------
Thanks Xiao for the work. {{MiniJournalCluster#waitActive}} LGTM. Regarding
[~jojochuang]'s question: I think the exception is expected if the IPC server
is not up yet. So the logic if catching such an exception and returning false
to {{waitFor}} -- meaning it should keep waiting -- looks OK.
The only question I have is whether we should call {{waitActive}} in all places
using {{MiniJournalCluster}}.
> Tests in TestDFSAdminWithHA intermittently fail with EOFException
> -----------------------------------------------------------------
>
> Key: HDFS-9429
> URL: https://issues.apache.org/jira/browse/HDFS-9429
> Project: Hadoop HDFS
> Issue Type: Test
> Components: test
> Reporter: Xiao Chen
> Assignee: Xiao Chen
> Attachments: HDFS-9429.001.patch, HDFS-9429.reproduce
>
>
> I have seen this fail a handful of times for {{testMetaSave}}, but from my
> understanding this is from {{setUpHaCluster}} so theoretically it could fail
> for any cases in the class.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)