[
https://issues.apache.org/jira/browse/HDFS-9429?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15026388#comment-15026388
]
Xiao Chen commented on HDFS-9429:
---------------------------------
Thanks Wei-Chiu and Zhe for the review.
Yes the IOE in waitActive is expected, and I fear printing it would cause
noise. Thanks Zhe for explaining. I added a comment here in the code.
bq. The only question I have is whether we should call {{waitActive}} in all
places using {{MiniJournalCluster}}.
I think the answer is yes. Although the test failures are only due to
{{MiniQJMHACluster}}, it's safer to call {{waitActive}} before proceeding. I
added the call to all found {{MiniJournalCluster}}.
Arguably we may call {{waitActive}} within
{{MiniJournalCluster#Builder#build}}, but that mixes the builder pattern with
additional logic, so I didn't do this. I guess this is why
{{MiniDFSCluster#Builder#build}} doesn't do it this way too.
Patch 2 is attached to reflex the above.
> Tests in TestDFSAdminWithHA intermittently fail with EOFException
> -----------------------------------------------------------------
>
> Key: HDFS-9429
> URL: https://issues.apache.org/jira/browse/HDFS-9429
> Project: Hadoop HDFS
> Issue Type: Test
> Components: test
> Reporter: Xiao Chen
> Assignee: Xiao Chen
> Attachments: HDFS-9429.001.patch, HDFS-9429.002.patch,
> HDFS-9429.reproduce
>
>
> I have seen this fail a handful of times for {{testMetaSave}}, but from my
> understanding this is from {{setUpHaCluster}} so theoretically it could fail
> for any cases in the class.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
