[
https://issues.apache.org/jira/browse/HDFS-9457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15026152#comment-15026152
]
BELUGA BEHR commented on HDFS-9457:
-----------------------------------
Thank you for your sincere interest!
I will work to review all logging in this file.
For this instance though, the guard seems necessary because there is some
Boolean logic happening to determine the correct log message. Does not seem
clean to perform the branch if the logger is not enabled:
{code}
if (info != null) {
// TRACE MSG 1
}
else
{
// TRACE MS 2
}
{code}
> Datanode Logging Improvement
> ----------------------------
>
> Key: HDFS-9457
> URL: https://issues.apache.org/jira/browse/HDFS-9457
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: datanode
> Affects Versions: 3.0.0, 2.7.0
> Reporter: BELUGA BEHR
> Priority: Trivial
> Attachments: Logging.diff
>
>
> Please accept my patch for some minor clean-up of logging. Patch is against
> 3.0.0 but applies to previous versions as well.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
