[
https://issues.apache.org/jira/browse/HDFS-1611?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Uma Maheswara Rao G updated HDFS-1611:
--------------------------------------
Description:
Title: Some code level logical issues.
Description:
1. DFSClient:
Consider the below case, if we enable only info, then below log will never be
logged.
if (ClientDatanodeProtocol.LOG.isDebugEnabled()) {
ClientDatanodeProtocol.LOG.info("ClientDatanodeProtocol addr=" + addr);
}
2.org.apache.hadoop.hdfs.server.namenode.FSNamesystem.registerMBean()
catch (NotCompliantMBeanException e) {
e.printStackTrace();
}
We can avoid using stackTace(). Better to add log message.
was:
Title: Some code level logical issues.
Description:
1. DFSClient:
Consider the below case, if we enable only info, then below log will never be
logged.
if (ClientDatanodeProtocol.LOG.isDebugEnabled()) {
ClientDatanodeProtocol.LOG.info("ClientDatanodeProtocol addr=" + addr);
}
2.org.apache.hadoop.hdfs.server.namenode.FSNamesystem.registerMBean()
catch (NotCompliantMBeanException e) {
e.printStackTrace();
}
We can avoid using stackTace(). Better to add log message.
3. In org.apache.hadoop.hdfs.server.namenode.FSImage
since SimpleDateFormat is not a thread safe, we can move that to local to
the method.
private static final SimpleDateFormat DATE_FORM =
new SimpleDateFormat("yyyy-MM-dd HH:mm:ss");
> Some logical issues need to address.
> ------------------------------------
>
> Key: HDFS-1611
> URL: https://issues.apache.org/jira/browse/HDFS-1611
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: hdfs client, name-node
> Affects Versions: 0.20.1, 0.20.2
> Reporter: Uma Maheswara Rao G
> Priority: Minor
>
> Title: Some code level logical issues.
> Description:
> 1. DFSClient:
> Consider the below case, if we enable only info, then below log will never
> be logged.
> if (ClientDatanodeProtocol.LOG.isDebugEnabled()) {
> ClientDatanodeProtocol.LOG.info("ClientDatanodeProtocol addr=" + addr);
> }
> 2.org.apache.hadoop.hdfs.server.namenode.FSNamesystem.registerMBean()
>
> catch (NotCompliantMBeanException e) {
> e.printStackTrace();
> }
> We can avoid using stackTace(). Better to add log message.
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
