[
https://issues.apache.org/jira/browse/HDFS-1611?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13002653#comment-13002653
]
Uma Maheswara Rao G commented on HDFS-1611:
-------------------------------------------
Verification Result:
For ths changes tests not required.
[exec] +1 overall.
[exec]
[exec] +1 @author. The patch does not contain any @author tags.
[exec]
[exec] -1 tests included. The patch doesn't appear to include any new
or modified tests.
[exec] Please justify why no new tests are needed
for this patch.
[exec] Also please list what manual steps were
performed to verify this patch.
[exec]
[exec] +1 javadoc. The javadoc tool did not generate any warning
messages.
[exec]
[exec] +1 javac. The applied patch does not increase the total number
of javac compiler warnings.
[exec]
[exec] +1 findbugs. The patch does not introduce any new Findbugs
(version 1.3.9) warnings.
[exec]
[exec] +1 release audit. The applied patch does not increase the
total number of release audit warnings.
[exec]
[exec] +1 system test framework. The patch passed system test
framework compile.
Tests are not required for this changes.That is the reason for -1.
> Some logical issues need to address.
> ------------------------------------
>
> Key: HDFS-1611
> URL: https://issues.apache.org/jira/browse/HDFS-1611
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: hdfs client, name-node
> Affects Versions: 0.20.1, 0.20.2
> Reporter: Uma Maheswara Rao G
> Priority: Minor
> Attachments: HDFS-1611.patch
>
>
> Title: Some code level logical issues.
> Description:
> 1. DFSClient:
> Consider the below case, if we enable only info, then below log will never
> be logged.
> if (ClientDatanodeProtocol.LOG.isDebugEnabled()) {
> ClientDatanodeProtocol.LOG.info("ClientDatanodeProtocol addr=" + addr);
> }
> 2.org.apache.hadoop.hdfs.server.namenode.FSNamesystem.registerMBean()
>
> catch (NotCompliantMBeanException e) {
> e.printStackTrace();
> }
> We can avoid using stackTace(). Better to add log message.
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
