[
https://issues.apache.org/jira/browse/HDFS-9537?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15053537#comment-15053537
]
Bob Hansen commented on HDFS-9537:
----------------------------------
[~James Clampffer] - thanks for the feedback.
bq. Why you need to deep copy the string into a char vector? Can this simply be
a reinterpret_cast on std::string::data?
The rapidxml library modifies the data in-place (in order to not do heap
allocations). As you noted, this is probably not performance-critical code,
but we want to be efficient wherever we can be.
bq. Based on some initial profiling it looks like we spend an awful amount of
time doing heap allocations.
Was that this code in particular, or libhdfs++ in general?
bq. The only other (incredibly pedantic) concern I have is the comment for
OverlayResourceString threw me off a bit.
I will make the comment more clear. Thanks for the feedback.
> libhdfs++: implement HDFSConfiguration class
> --------------------------------------------
>
> Key: HDFS-9537
> URL: https://issues.apache.org/jira/browse/HDFS-9537
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: hdfs-client
> Reporter: Bob Hansen
> Assignee: Bob Hansen
> Attachments: HDFS-9537.HDFS-8707.000.patch,
> HDFS-9537.HDFS-8707.001.patch
>
>
> Create a class to encode the rules for interpreting a Configuration class to
> create a libhdfs++ Options object
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
