[
https://issues.apache.org/jira/browse/HDFS-9537?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15053649#comment-15053649
]
James Clampffer commented on HDFS-9537:
---------------------------------------
Thanks for the updates!
"The rapidxml library modifies the data in-place (in order to not do heap
allocations). As you noted, this is probably not performance-critical code, but
we want to be efficient wherever we can be."
Sounds good to me. Thanks for the explanation.
"Was that this code in particular, or libhdfs++ in general?"
This was libhdfs++ in general, I only pointed it out here because tests were
fresh in my memory. I ran vallgrind dhat and callgrind a few days ago and we
spend a significant amount of time allocating tons strings. The majority was
protobuf copying it's own representation to std::strings. According to the
test 29% of the runtime was spent there, but it was a very short test so I
suspect it could have been counting the time it took for logically allocated
pages to fault in. Reducing the existing allocations aren't a priority of mine
at the moment but the less new ones we add the better.
"""
// Loads Configuration XML contained in a string and produces a new copy that
// is the union of the src and xml_data
// Any parameters from src will be overwritten by the xml_data unless they
// are marked as "final" in src.
"""
Looks good to me.
I just want to run through this once more with fresh eyes tomorrow before I +1.
> libhdfs++: implement HDFSConfiguration class
> --------------------------------------------
>
> Key: HDFS-9537
> URL: https://issues.apache.org/jira/browse/HDFS-9537
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: hdfs-client
> Reporter: Bob Hansen
> Assignee: Bob Hansen
> Attachments: HDFS-9537.HDFS-8707.000.patch,
> HDFS-9537.HDFS-8707.001.patch, HDFS-9537.HDFS-8707.002.patch
>
>
> Create a class to encode the rules for interpreting a Configuration class to
> create a libhdfs++ Options object
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
