[
https://issues.apache.org/jira/browse/HDFS-9498?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15083740#comment-15083740
]
Arpit Agarwal commented on HDFS-9498:
-------------------------------------
Hi [~liuml07], is this new call to fix a pre-existing bug? The call looks
redundant as {{BlockManagerSafeMode#leaveSafeMode}} called the same function
earlier.
{code}
- setManualAndResourceLowSafeMode(false, false);
- blockManager.leaveSafeMode(true);
+ if (blockManager.leaveSafeMode(force)) {
+ setManualAndResourceLowSafeMode(false, false);
+ startSecretManagerIfNecessary();
+ }
{code}
> Move code that tracks orphan blocks to BlockManagerSafeMode
> -----------------------------------------------------------
>
> Key: HDFS-9498
> URL: https://issues.apache.org/jira/browse/HDFS-9498
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: namenode
> Reporter: Mingliang Liu
> Assignee: Mingliang Liu
> Attachments: HDFS-9498.000.patch, HDFS-9498.001.patch,
> HDFS-9498.002.patch, HDFS-9498.003.patch
>
>
> [HDFS-4015] counts and reports orphaned blocks
> {{numberOfBytesInFutureBlocks}} in safe mode. It was implemented in
> {{BlockManager}}. Per discussion in [HDFS-9129] which introduces the
> {{BlockManagerSafeMode}}, we can move code that maintaining orphaned blocks
> to this class.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
