[
https://issues.apache.org/jira/browse/HDFS-9498?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15083965#comment-15083965
]
Arpit Agarwal commented on HDFS-9498:
-------------------------------------
Okay that makes sense. I missed the side effect of moving the
setManualAndResourceLowSafeMode call.
I wish there was a more straightforward way to do it. The extra call to
startSecretManagerIfNecessary looks out of place but your approach is the
easiest fix for now. +1 with the {{orphanBlocks}} terminology fixed.
[~anu], does the v3 patch look okay to you?
> Move code that tracks orphan blocks to BlockManagerSafeMode
> -----------------------------------------------------------
>
> Key: HDFS-9498
> URL: https://issues.apache.org/jira/browse/HDFS-9498
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: namenode
> Reporter: Mingliang Liu
> Assignee: Mingliang Liu
> Attachments: HDFS-9498.000.patch, HDFS-9498.001.patch,
> HDFS-9498.002.patch, HDFS-9498.003.patch
>
>
> [HDFS-4015] counts and reports orphaned blocks
> {{numberOfBytesInFutureBlocks}} in safe mode. It was implemented in
> {{BlockManager}}. Per discussion in [HDFS-9129] which introduces the
> {{BlockManagerSafeMode}}, we can move code that maintaining orphaned blocks
> to this class.
> Leaving safe mode checks blocks with future GS in {{FSNamesystem}}. This code
> can also be moved to {{BlockManagerSafeMode}}.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
