[
https://issues.apache.org/jira/browse/HDFS-8999?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15086101#comment-15086101
]
Jing Zhao commented on HDFS-8999:
---------------------------------
# How about making BlockNotYetCompleteException simply an IOException and then
in {{appendFile}} wrapping it inside of a {{RetriableException}} (like the
current {{checkNameNodeSafeMode}})? In this way we can depend on the existing
retry logic fo {{RetriableException}} and do not need to have explicit retry in
{{callAppend}}.
# We may need a unit test for the append retry in a block-not-yet-complete
scenario.
# In {{commitOrCompleteLastBlock}} and {{addStoredBlock}}, looks like we do not
need the {{hasMinStorage}} check when adding the replicas to the pending queue?
Otherwise the block may be later put into the under-replicated queue with
{{QUEUE_WITH_CORRUPT_BLOCKS}} priority. If this change makes sense to you, we
may also need another unit test here.
{code}
if (hasMinStorage(lastBlock)) {
if (b) {
addExpectedReplicasToPending(lastBlock, bc);
}
{code}
> Namenode need not wait for {{blockReceived}} for the last block before
> completing a file.
> -----------------------------------------------------------------------------------------
>
> Key: HDFS-8999
> URL: https://issues.apache.org/jira/browse/HDFS-8999
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: namenode
> Reporter: Jitendra Nath Pandey
> Assignee: Tsz Wo Nicholas Sze
> Attachments: h8999_20151228.patch, h8999_20160106.patch,
> h8999_20160106b.patch, h8999_20160106c.patch
>
>
> This comes out of a discussion in HDFS-8763. Pasting [~jingzhao]'s comment
> from the jira:
> {quote}
> ...whether we need to let NameNode wait for all the block_received msgs to
> announce the replica is safe. Looking into the code, now we have
> # NameNode knows the DataNodes involved when initially setting up the
> writing pipeline
> # If any DataNode fails during the writing, client bumps the GS and
> finally reports all the DataNodes included in the new pipeline to NameNode
> through the updatePipeline RPC.
> # When the client received the ack for the last packet of the block (and
> before the client tries to close the file on NameNode), the replica has been
> finalized in all the DataNodes.
> Then in this case, when NameNode receives the close request from the client,
> the NameNode already knows the latest replicas for the block. Currently the
> checkReplication call only counts in all the replicas that NN has already
> received the block_received msg, but based on the above #2 and #3, it may be
> safe to also count in all the replicas in the
> BlockUnderConstructionFeature#replicas?
> {quote}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
