[
https://issues.apache.org/jira/browse/HDFS-8999?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15094154#comment-15094154
]
Tsz Wo Nicholas Sze commented on HDFS-8999:
-------------------------------------------
> 1. How about making BlockNotYetCompleteException simply an IOException ...
Sure
> 2. We may need a unit test for the append retry in a block-not-yet-complete
> scenario.
TestAppendDifferentChecksum#testAlgoSwitchRandomized has a similar scenario. I
am also going to add a new test.
> 3. In commitOrCompleteLastBlock and addStoredBlock, looks like we do not
> need the hasMinStorage check when adding the replicas to the pending queue?
> ...
I like to keep the hasMinStorage check since commitOrCompleteLastBlock and
addStoredBlock check whether a block is updated from COMMITTED to COMPLETE. If
yes, added it to pendingReplications.
In this patch, we allow file close for COMMITTED blocks. I think we should add
the COMMITTED blocks to pendingReplications when the file is being closed. The
existing logic (add a block to pendingReplications if it changes from COMMITTED
to COMPLETE) should not be changed. How does it sound to you?
> Namenode need not wait for {{blockReceived}} for the last block before
> completing a file.
> -----------------------------------------------------------------------------------------
>
> Key: HDFS-8999
> URL: https://issues.apache.org/jira/browse/HDFS-8999
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: namenode
> Reporter: Jitendra Nath Pandey
> Assignee: Tsz Wo Nicholas Sze
> Attachments: h8999_20151228.patch, h8999_20160106.patch,
> h8999_20160106b.patch, h8999_20160106c.patch, h8999_20160111.patch
>
>
> This comes out of a discussion in HDFS-8763. Pasting [~jingzhao]'s comment
> from the jira:
> {quote}
> ...whether we need to let NameNode wait for all the block_received msgs to
> announce the replica is safe. Looking into the code, now we have
> # NameNode knows the DataNodes involved when initially setting up the
> writing pipeline
> # If any DataNode fails during the writing, client bumps the GS and
> finally reports all the DataNodes included in the new pipeline to NameNode
> through the updatePipeline RPC.
> # When the client received the ack for the last packet of the block (and
> before the client tries to close the file on NameNode), the replica has been
> finalized in all the DataNodes.
> Then in this case, when NameNode receives the close request from the client,
> the NameNode already knows the latest replicas for the block. Currently the
> checkReplication call only counts in all the replicas that NN has already
> received the block_received msg, but based on the above #2 and #3, it may be
> safe to also count in all the replicas in the
> BlockUnderConstructionFeature#replicas?
> {quote}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
