[
https://issues.apache.org/jira/browse/HDFS-9094?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15098831#comment-15098831
]
Arpit Agarwal commented on HDFS-9094:
-------------------------------------
Thanks for the updated patch [~xiaobingo]. Looks like we need the
<datanode|namenode> parameter after all for setting the server principal.
The patch looks good. Tried it out locally and looks good. Just a couple of
things:
# The else clause below should be {{else if ("namenode".equals(nodeType))...}}.
Currently any string other than {{datanode}} dispatches to the NameNode. Needs
fixing in startReconfigurationDispatch, getReconfigurationStatusDispatch and
getReconfigurablePropertiesDispatch. Alternatively you can move the check to
the {{reconfig}} method.
{code}
if ("datanode".equals(nodeType)) {
ClientDatanodeProtocol reconfProxy = getDataNodeProxy(address);
reconfProxy.startReconfiguration();
} else {
{code}
# Few unused imports in DFSAdmin.java.
+1 with that addressed.
> Add command line option to ask NameNode reload configuration.
> -------------------------------------------------------------
>
> Key: HDFS-9094
> URL: https://issues.apache.org/jira/browse/HDFS-9094
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: namenode
> Affects Versions: 2.7.0
> Reporter: Xiaobing Zhou
> Assignee: Xiaobing Zhou
> Attachments: HDFS-9094-HDFS-9000.002.patch,
> HDFS-9094-HDFS-9000.003.patch, HDFS-9094-HDFS-9000.004.patch,
> HDFS-9094-HDFS-9000.005.patch, HDFS-9094.001.patch
>
>
> This work is going to add DFS admin command that allows reloading NameNode
> configuration. This is sibling work related to HDFS-6808.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
