[
https://issues.apache.org/jira/browse/HDFS-9094?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15109051#comment-15109051
]
Arpit Agarwal commented on HDFS-9094:
-------------------------------------
Hi [~xiaobingo], the patch looks great. Just a couple of nitpicks:
# startReconfigurationDispatch, getReconfigurationStatusDispatch,
getReconfigurablePropertiesDispatch - The error message should go to the error
stream.
{code}
out.println(String.format("Unrecognized node type: %s", nodeType));
{code}
# Also you could skip calling String.format and just use concat the strings.
Your call.
# Missing blank line after line 505 in DFSUtilClient.java.
> Add command line option to ask NameNode reload configuration.
> -------------------------------------------------------------
>
> Key: HDFS-9094
> URL: https://issues.apache.org/jira/browse/HDFS-9094
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: namenode
> Affects Versions: 2.7.0
> Reporter: Xiaobing Zhou
> Assignee: Xiaobing Zhou
> Attachments: HDFS-9094-HDFS-9000.002.patch,
> HDFS-9094-HDFS-9000.003.patch, HDFS-9094-HDFS-9000.004.patch,
> HDFS-9094-HDFS-9000.005.patch, HDFS-9094-HDFS-9000.006.patch,
> HDFS-9094.001.patch
>
>
> This work is going to add DFS admin command that allows reloading NameNode
> configuration. This is sibling work related to HDFS-6808.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
