[
https://issues.apache.org/jira/browse/HDFS-9647?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15109830#comment-15109830
]
Lei (Eddy) Xu commented on HDFS-9647:
-------------------------------------
Hi, [~anu] thanks a lot for working on this feature.
I have a few questions regarding to this patch.
{code}
message DiskBalancerSettingResponseProto {
required string key = 1;
...
}
{code}
Why do we need to set key in the response? Would it be the same as the key in
the request?
{code}
@param key - String that represents the run time key value.
{code}
Would you mind to rephrase it to {{@param key the runtime configuration key}}?
{code}
public String getDiskBalancerSetting(String key) throws IOException {
checkSuperuserPrivilege();
throw new DiskbalancerException("Not Implemented", 0);
}
{code}
Does this function depends on HDFS-9645?
{code}
public void TestSettingRpc() {
...
}
{code}
Would you mind to change its name to {{testgetDiskBalancerSetting}}? And fill
the code after HDFS-9645 being committed?
{code}
public final class DiskBalancerConstants {
static final String DISKBALANCER_BANDWIDTH = "DiskBalancerBandwidth";
static final String DISKBALANCER_VOLUME_NAME = "DiskBalancerVolumeName";
{code}
Would you clarify the expected users for these constants? The visibility of the
class and fields being different is a little confusing. It'd be nice to put
{{@InterfaceAudience}} to indicate the expected components that can access
these constants.
Thanks again!
> DiskBalancer : Add getRuntimeSettings
> -------------------------------------
>
> Key: HDFS-9647
> URL: https://issues.apache.org/jira/browse/HDFS-9647
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: balancer & mover
> Affects Versions: HDFS-1312
> Reporter: Anu Engineer
> Assignee: Anu Engineer
> Fix For: HDFS-1312
>
> Attachments: HDFS-9647-HDFS-1312.001.patch
>
>
> Adds an RPC to read the runtime values of disk balancer like disk bandwidth.
> This is similar to getdiskbandwidth used by balancer
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
