[
https://issues.apache.org/jira/browse/HDFS-9647?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15109866#comment-15109866
]
Anu Engineer commented on HDFS-9647:
------------------------------------
[~eddyxu] Thanks for your comments.
bq. Why do we need to set key in the response? Would it be the same as the key
in the request?
You are right we can remove it, the key will always be same. I just wanted to
associate the calling context with the reply. Since we only have synchronous
calls, it makes sense to remove the Key in the reply.
bq. Would you mind to rephrase it to @param key the runtime configuration key?
Will do.
bq. Does this function depends on HDFS-9645?
These patches are all working against the same files. So I have ordered them so
as to avoid patch conflicts. It is semantically all separate code.
bq. Would you mind to change its name to testgetDiskBalancerSetting And fill
the code after HDFS-9645 being committed?
Yes and Yes.
bq. It'd be nice to put @InterfaceAudience to indicate the expected components
that can access these constants.
Will do.
I will upload a new patch which addresses all your suggestions.
> DiskBalancer : Add getRuntimeSettings
> -------------------------------------
>
> Key: HDFS-9647
> URL: https://issues.apache.org/jira/browse/HDFS-9647
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: balancer & mover
> Affects Versions: HDFS-1312
> Reporter: Anu Engineer
> Assignee: Anu Engineer
> Fix For: HDFS-1312
>
> Attachments: HDFS-9647-HDFS-1312.001.patch
>
>
> Adds an RPC to read the runtime values of disk balancer like disk bandwidth.
> This is similar to getdiskbandwidth used by balancer
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
