[ 
https://issues.apache.org/jira/browse/HDFS-9730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15127193#comment-15127193
 ] 

Kihwal Lee commented on HDFS-9730:
----------------------------------

bq. I am not quite sure I understand why the current unit tests are actually 
passing
The datanode layout version(-56) hasn't changed in trunk or branch-2.7. So the 
test won't go through the layout update path. If the test case used an older 
layout version, it would have failed. HDFS-7575 was created with the test 
resource containing datanode layout version -56. 

> Storage ID update does not happen when there is a layout change
> ---------------------------------------------------------------
>
>                 Key: HDFS-9730
>                 URL: https://issues.apache.org/jira/browse/HDFS-9730
>             Project: Hadoop HDFS
>          Issue Type: Bug
>            Reporter: Kihwal Lee
>
> HDFS-9654 will cause test failures when we increment the datanode layout 
> version next time.
> {noformat}
> TestDatanodeStartupFixesLegacyStorageIDs#testUpgradeFrom22via26FixesStorageIDs
> TestDatanodeStartupFixesLegacyStorageIDs#testUpgradeFrom22FixesStorageIDs
> {noformat}
> This is because createStorageID() is no longer called when it goes through 
> the layout upgrade path. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to