[
https://issues.apache.org/jira/browse/HDFS-9812?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15148131#comment-15148131
]
Lin Yiqun commented on HDFS-9812:
---------------------------------
All the test are passed, the fix looks fine to the current code. I did a code
review to find similar issues in {{DfsOutputStream}}. The flushing data method
{{DfsOutputStream#flushInternal}} is only used in
{{DfsOutputStream#closeImpl}}, it seems that the case of this is the only place
that will lead to streamer thread leak.
> Streamer threads leak if failure happens when closing the dfsoutputstream
> -------------------------------------------------------------------------
>
> Key: HDFS-9812
> URL: https://issues.apache.org/jira/browse/HDFS-9812
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: hdfs-client
> Affects Versions: 2.7.1
> Reporter: Lin Yiqun
> Assignee: Lin Yiqun
> Attachments: HDFS.001.patch
>
>
> In HDFS-9794, it has solved problem of that stream thread leak if failure
> happens when closing the striped outputstream. And in {{DfsOutpuStream}}, it
> also exists the same problem in {{DfsOutpuStream#closeImpl}}. If failures
> happen when flushing data blocks, the streamer threads will also not be
> closed.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
