[
https://issues.apache.org/jira/browse/HDFS-9812?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15158493#comment-15158493
]
Akira AJISAKA commented on HDFS-9812:
-------------------------------------
Thanks [~linyiqun] for contributing to this issue.
bq. There are many places doesn't judging LOG.isDebugEnabled() when logging
debug info in DFSOutputStream and DataStreamer.
There is no need to use {{LOG.isDebugEnabled()}} when the logging is the
following format (e.g. "+" is not used):
{code}
LOG.debug("Connecting to datanode {}", dnAddr);
{code}
Please see the Logging section of
https://github.com/steveloughran/formality/blob/master/styleguide/styleguide.md
for the detail.
> Streamer threads leak if failure happens when closing the dfsoutputstream
> -------------------------------------------------------------------------
>
> Key: HDFS-9812
> URL: https://issues.apache.org/jira/browse/HDFS-9812
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: hdfs-client
> Affects Versions: 2.7.1
> Reporter: Lin Yiqun
> Assignee: Lin Yiqun
> Attachments: HDFS-9812.002.patch, HDFS.001.patch
>
>
> In HDFS-9794, it has solved problem of that stream thread leak if failure
> happens when closing the striped outputstream. And in {{DfsOutpuStream}}, it
> also exists the same problem in {{DfsOutpuStream#closeImpl}}. If failures
> happen when flushing data blocks, the streamer threads will also not be
> closed.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
