[ https://issues.apache.org/jira/browse/HDFS-9816?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15153436#comment-15153436 ]
Zhe Zhang commented on HDFS-9816: --------------------------------- bq. Zhe Zhang, regarding your last comment, which test do you mean by testSafeLength? I don't see such a test in TestLeaseRecoveryStriped. Sorry I didn't mention. It is in {{TestBlockRecovery}}. bq. Shall I add a public static method in RecoveryTaskStriped Sounds good. I think we can divide the current {{RecoveryTaskStriped#getSafeLength}} into 2 methods, the second one (starting from {{Arrays.sort(blockLengths)}}) can be made public static. If you can find a good place to put it as an util method that's even better. So to recap, I think we have agreed to 1) keep {{getBlockLengthsSuite}}; 2) create a public static method to calculate safe length in both main and test codes; 3) add hard-coded length numbers for {{TestBlockRecovery#testSafeLength}}. > Erasure Coding: allow to use multiple EC policies in striping related tests > [Part 3] > ------------------------------------------------------------------------------------ > > Key: HDFS-9816 > URL: https://issues.apache.org/jira/browse/HDFS-9816 > Project: Hadoop HDFS > Issue Type: Sub-task > Components: erasure-coding, test > Reporter: Rui Li > Assignee: Rui Li > Attachments: HDFS-9816.1.patch > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)