[ 
https://issues.apache.org/jira/browse/HDFS-9733?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15162700#comment-15162700
 ] 

Kai Zheng commented on HDFS-9733:
---------------------------------

The update didn't fix check styles like below. I'm thinking the variables will 
be revisited in subsequent tasks like HDFS-9694. [~umamaheswararao] please let 
me know if you'd prefer they're fixed here. Thanks.
{code}
long crcPerBlock = 0;:10: Variable 'crcPerBlock' must be private and have 
accessor methods.
{code}

> Refactor DFSClient#getFileChecksum and DataXceiver#blockChecksum
> ----------------------------------------------------------------
>
>                 Key: HDFS-9733
>                 URL: https://issues.apache.org/jira/browse/HDFS-9733
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>            Reporter: Kai Zheng
>            Assignee: Kai Zheng
>         Attachments: HDFS-9733-v1.patch, HDFS-9733-v2.patch, 
> HDFS-9733-v3.patch, HDFS-9733-v4.patch, HDFS-9733-v5.patch, HDFS-9733-v6.patch
>
>
> To prepare for file checksum computing for striped files, this refactors the 
> existing codes in Refactor {{DFSClient#getFileChecksum}} and 
> {{DataXceiver#blockChecksum}} to make HDFS-8430 and HDFS-9694 easier.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to