[
https://issues.apache.org/jira/browse/HDFS-9702?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15181316#comment-15181316
]
Lei (Eddy) Xu commented on HDFS-9702:
-------------------------------------
Hey, [~anu]
The patch looks good in general. Will +1 once addressing the following concerns:
* In many tests, it has the following code
{code}
thrown.expect(DiskBalancerException.class);
{code}
Could you directly check it against the {{Enum Result}} in
{{DiskBalanceException}}, otherwise, it might just mark other potential errors.
Thanks.
> DiskBalancer : getVolumeMap implementation
> ------------------------------------------
>
> Key: HDFS-9702
> URL: https://issues.apache.org/jira/browse/HDFS-9702
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: balancer & mover
> Affects Versions: HDFS-1312
> Reporter: Anu Engineer
> Assignee: Anu Engineer
> Fix For: HDFS-1312
>
> Attachments: HDFS-9702-HDFS-1312.001.patch
>
>
> Add get volume map
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
